-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1357844: fix flaky test caused by oob telemetry datetime comparsion #1513
Conversation
@sfc-gh-aling could you please |
@sfc-gh-mvashishtha I changed to use mock, we shall be good now. thanks for the suggestion command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfc-gh-aling one more nit
command pytest tests/mock_unit/test_oob_telemetry.py::test_unit_oob_log_not_implemented_error --count 1000 -n 32 passes
Thanks for checking, but it seems to pass on the main branch as well, so it doesn't reproduce the flake. That's okay. I think mocking the time should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1357844
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
pytest.approx only supports number, datetime is not supported, so previously implementation doesn't work at all.
change to use timestamp to the approx equal