Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1347394: Close parentheses in SnowflakeQueryCompiler.default_to_pandas message #1501

Merged
merged 1 commit into from
May 2, 2024

Conversation

sfc-gh-joshi
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1347394

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

)

@sfc-gh-joshi sfc-gh-joshi requested a review from a team as a code owner May 2, 2024 20:22
Copy link
Contributor

@sfc-gh-rdurrani sfc-gh-rdurrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but additional args are added that weren't passed in by user?

Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-joshi
Copy link
Contributor Author

@sfc-gh-rdurrani yeah, unfortunately at the query compiler layer I don't think there's a way we can distinguish between arguments that the user explicitly provided vs. arguments that our frontend/QC automatically filled in. We'd have to explicitly fail specific APIs at the frontend layer (or on a per-method basis in the query compiler) if we want to use more discretion with what arguments are shown.

@sfc-gh-joshi sfc-gh-joshi added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGELOG-UPDATES NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels May 2, 2024
@sfc-gh-joshi sfc-gh-joshi merged commit 4de8cf4 into main May 2, 2024
25 of 26 checks passed
@sfc-gh-joshi sfc-gh-joshi deleted the joshi-SNOW-1347394-close-paren branch May 2, 2024 22:16
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants