Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1013917]: Add support for pivot_table without index parameter #1488

Merged
merged 22 commits into from
May 22, 2024
Merged

[SNOW-1013917]: Add support for pivot_table without index parameter #1488

merged 22 commits into from
May 22, 2024

Conversation

sfc-gh-rdurrani
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1013917

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

Add support for pivot_table without an index parameter.

@sfc-gh-rdurrani sfc-gh-rdurrani requested a review from a team as a code owner May 2, 2024 04:11
@sfc-gh-rdurrani sfc-gh-rdurrani marked this pull request as draft May 2, 2024 04:11
@sfc-gh-rdurrani sfc-gh-rdurrani added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels May 7, 2024
@sfc-gh-rdurrani sfc-gh-rdurrani marked this pull request as ready for review May 7, 2024 22:23
sfc-gh-vbudati
sfc-gh-vbudati approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-vbudati sfc-gh-vbudati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, just some minor suggestions. Thanks Rehan!

src/snowflake/snowpark/modin/plugin/_internal/pivot_utils.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/pivot_utils.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/pivot_utils.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/pivot_utils.py Outdated Show resolved Hide resolved
@sfc-gh-evandenberg
Copy link
Collaborator

Should this commit be into pandas-main rather than main?

@sfc-gh-evandenberg
Copy link
Collaborator

sfc-gh-evandenberg commented May 9, 2024 •
edited
Loading

The jira title is actually "Implement pivot_table with no groupby columns" and there are tests and support for no index (See test_pivot_table_no_index_single_column_single_value in test_pivot_single.py). This fix is specifically a subset of the cases?

sfc-gh-evandenberg
sfc-gh-evandenberg approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-evandenberg sfc-gh-evandenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with questions addressed.

@sfc-gh-rdurrani
Copy link
Contributor Author

The jira title is actually "Implement pivot_table with no groupby columns" and there are tests and support for no index (See test_pivot_table_no_index_single_column_single_value in test_pivot_single.py). This fix is specifically a subset of the cases?

This PR adds support for pivot_table with index=None - the test cases are just testing the different permutations for when index=None.

sfc-gh-helmeleegy
sfc-gh-helmeleegy reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update dataframe_supported.rst?

sfc-gh-helmeleegy
sfc-gh-helmeleegy reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update the docstring in src/snowflake/snowpark/modin/plugin/docstrings/dataframe.py.

sfc-gh-helmeleegy
sfc-gh-helmeleegy requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a few remaining documentation updates.

sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the required changes. Looks great!

sfc-gh-vbudati
sfc-gh-vbudati approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-vbudati sfc-gh-vbudati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thanks Rehan! Just have a suggestion to break up the giant function into smaller ones.

@sfc-gh-rdurrani sfc-gh-rdurrani requested a review from a team as a code owner May 17, 2024 22:08
sfc-gh-azhan
sfc-gh-azhan requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and update changelog.md in 1.18.0

@sfc-gh-rdurrani sfc-gh-rdurrani requested a review from a team as a code owner May 21, 2024 20:52
@sfc-gh-jrose sfc-gh-jrose removed their request for review May 21, 2024 20:55
@sfc-gh-rdurrani sfc-gh-rdurrani enabled auto-merge (squash) May 22, 2024 00:07
@sfc-gh-rdurrani sfc-gh-rdurrani removed NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels May 22, 2024
@sfc-gh-rdurrani sfc-gh-rdurrani merged commit afaf725 into main May 22, 2024
37 of 38 checks passed
@sfc-gh-rdurrani sfc-gh-rdurrani deleted the rdurrani-SNOW-1013917 branch May 22, 2024 17:42
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-vbudati sfc-gh-vbudati sfc-gh-vbudati approved these changes

@sfc-gh-evandenberg sfc-gh-evandenberg sfc-gh-evandenberg approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-nkumar sfc-gh-nkumar Awaiting requested review from sfc-gh-nkumar sfc-gh-nkumar was automatically assigned from snowflakedb/snowpandas

@sfc-gh-dpetersohn sfc-gh-dpetersohn Awaiting requested review from sfc-gh-dpetersohn sfc-gh-dpetersohn is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang was automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam was automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sfc-gh-rdurrani @sfc-gh-evandenberg @sfc-gh-azhan @sfc-gh-stan @sfc-gh-vbudati @sfc-gh-helmeleegy