-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1320543 Update modin class paths #1469
SNOW-1320543 Update modin class paths #1469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! What's the downside of permanently leaving it as "alabaster" it's so much nicer lol
@sfc-gh-nkrishna I have no idea lol. There was a comment in the ol' snowpandas fork that mentioned "switching back to the empty theme once merged back". Just following orders, although it is a very nice theme. 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for figuring this out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with doc generation, but you should be able to verify your change through the doc in the generated artifacts: https://github.com/snowflakedb/snowpark-python/actions/runs/8902614293?pr=1469#artifacts
@sfc-gh-joshi @sfc-gh-nkrishna I was double checking the docs generated by this code: I'm not sure how to fix this, not sure if this is worth fixing. All the other APIs are displayed correctly. The headings are displayed correctly - this is just the module line that has the "full" classpath present in the aforementioned files. What do you think? Take a look at the docs for:
|
@sfc-gh-vbudati This is behavior we should run by Sri/Brenan I think. Maybe worth a post on the channel? IMO this isn't a big deal since the repo is public anyways so any user can see the file path/structure if they wanted to. |
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1320543
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Change modin classpaths from
snowflake.snowpark.modin.pandas.<>
tomodin.pandas.<>
.To see the changes locally run:
To see the docs in a nice format, change the variable
html_theme
indocs/source/conf.py:70
to"alabaster"
.