Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-853533: Support case sensitivity in to_local_iterator #1096

Merged
merged 6 commits into from
Oct 25, 2023
Merged

SNOW-853533: Support case sensitivity in to_local_iterator #1096

merged 6 commits into from
Oct 25, 2023

Conversation

cindykrafft
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-853533: to_local_iterator doesn't support generating rows as case-insensitive  #926

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Adds case_sensitive keyword arg and passes through to self._session._conn.execute.

@cindykrafft cindykrafft requested a review from a team as a code owner October 19, 2023 00:03
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@cindykrafft
Copy link
Contributor Author

cindykrafft commented Oct 19, 2023 •
edited
Loading

I have read the CLA Document and I hereby sign the CLA

sfc-gh-stan
sfc-gh-stan approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-stan sfc-gh-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, I've kicked off the merge gates in #1099

@sfc-gh-aling
Copy link
Contributor

thanks for the PR, can you also help update the changelog? https://github.com/snowflakedb/snowpark-python/blob/main/CHANGELOG.md

@cindykrafft
Copy link
Contributor Author

thanks for the PR, can you also help update the changelog? https://github.com/snowflakedb/snowpark-python/blob/main/CHANGELOG.md

Done

@sfc-gh-sfan sfc-gh-sfan merged commit b843c3f into snowflakedb:main Oct 25, 2023
59 of 102 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-mkeller sfc-gh-mkeller Awaiting requested review from sfc-gh-mkeller sfc-gh-mkeller was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-achandrasekaran sfc-gh-achandrasekaran Awaiting requested review from sfc-gh-achandrasekaran sfc-gh-achandrasekaran was automatically assigned from snowflakedb/snowpark-python-api

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-853533: to_local_iterator doesn't support generating rows as case-insensitive
4 participants
@cindykrafft @sfc-gh-aling @sfc-gh-stan @sfc-gh-sfan