Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-754087: Remove xfail from if_not_exists tests #1065

Merged

Conversation

sfc-gh-aalam
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 27, 2023
@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review September 28, 2023 16:42
@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner September 28, 2023 16:42
@sfc-gh-aalam
Copy link
Contributor Author

@sfc-gh-aalam
Copy link
Contributor Author

The fix for it has been released in 7.34. Hopefully that fixes the flakiness: https://snowflakecomputing.atlassian.net/browse/SNOW-542158

@sfc-gh-aalam sfc-gh-aalam merged commit e93d054 into main Sep 29, 2023
50 of 51 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-754087-fix-flaky-test-test-udf-if-not-exists branch September 29, 2023 17:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants