Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-925456: session.write_pandas() behavior inconsistent with underlying snowflake.connector.pandas_tools.write_pandas() #1063

Closed
sfc-gh-madkins opened this issue Sep 27, 2023 · 0 comments
Labels
bug Something isn't working needs triage Initial RCA is required

Comments

@sfc-gh-madkins
Copy link
Contributor

sfc-gh-madkins commented Sep 27, 2023

Please answer these questions before submitting your issue. Thanks!

  1. What version of Python are you using?

3.8

  1. What operating system and processor architecture are you using?

    macOS-13.6-arm64-arm-64bit

  2. What are the component versions in the environment (pip freeze)?

    Replace with the output of python -m pip freeze

  3. What did you do?

In https://github.com/snowflakedb/snowpark-python/blob/main/src/snowflake/snowpark/session.py, we

from snowflake.connector.pandas_tools import write_pandas

which is a much better/more robust version that does schema inference ... and we call out its use as well in def create_dataframe

When data is a pandas DataFrame, snowflake.connector.pandas_tools.write_pandas is called ...

but there also exists a def write_pandas that overrides the import and is missing some of the things in the other one

  1. What did you expect to see?

    leverage snowflake.connector.pandas_tools.write_pandas

@sfc-gh-madkins sfc-gh-madkins added bug Something isn't working needs triage Initial RCA is required labels Sep 27, 2023
@github-actions github-actions bot changed the title session.write_pandas() behavior inconsistent with underlying snowflake.connector.pandas_tools.write_pandas() SNOW-925456: session.write_pandas() behavior inconsistent with underlying snowflake.connector.pandas_tools.write_pandas() Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Initial RCA is required
Projects
None yet
Development

No branches or pull requests

1 participant