Typing

[alexmojaki]

This is an attempt to make some progress on #1055. Before this PR, pyright reports 625 errors, afterwards it reports 468. In particular I resolved all the type errors in src/snowflake/snowpark/_internal/analyzer/.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[alexmojaki]

I have read the CLA Document and I hereby sign the CLA

[sfc-gh-sfan]

Test pr in #1061

[sfc-gh-sfan]

tests/integ/scala/test_snowflake_plan_suite.py:78: in test_multiple_queries
    plan2 = SnowflakePlan(
E   TypeError: SnowflakePlan.__init__() missing 1 required keyword-only argument: 'session'

[sfc-gh-stan]

I wonder if the default should be 38.

[sfc-gh-sfan]

What happens today if it is None?

[sfc-gh-stan]

This is only None when the result is not Decimal type, where the parameter would not be used in convert_sf_to_sp_type. So technically the most "rigorous" way of writing this is checking the column type in convert_result_meta_to_attribute and define convert_sf_to_sp_type separately.

[sfc-gh-stan]

Sorry all, I messed up a rebase and had to create a new test pr: #1095

[sfc-gh-sfan]

What happens today if it is None?

[sfc-gh-mkeller]

🚢 🚢

[sfc-gh-stan]

After discussing with @sfc-gh-mkeller , we have decided to use mypy as the source of truth for type checking. We will refer to the mypy configuration from the upstream snowflakedb/snowflake-connector-python@eee76d1#diff-6f2d4ba9ca9a357d31014946667b7bed1bfdbc6d2530afc77778fa0a36bee457. Ideally speaking this should not conflict with pyright checks, so I will keep the pyright merge gate, but mypy takes precedence if such conflict arise. I will mark the pyright merge gate as optional when we add mypy in the CI.