-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default config reading import #1042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to add this function to sp connector even if it is just a no-op to reduce the stored proc check we have in code. Can you create a ticket to track that?
@@ -21,7 +21,6 @@ | |||
import pkg_resources | |||
|
|||
from snowflake.connector import ProgrammingError, SnowflakeConnection | |||
from snowflake.connector.config_manager import _get_default_connection_params |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably can do is_in_stored_procedure()
check for the import? And for safety, also add the same check in the if clause before calling the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry does not mean to approve yet
c98b1b0
to
3225e9e
Compare
sure, created https://snowflakecomputing.atlassian.net/browse/SNOW-911000 |
This is still breaking https://ci-dev-142.int.snowflakecomputing.com/job/AnacondaPackageBuilder-x86/ @sfc-gh-jdu can you look into this and verify if our precommit test is happy? |
The original import won't work in stored procedure, so we need to import it inside the create function