Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snowpark] Add arg for volatile/immutable UDF #1038

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[Snowpark] Add arg for volatile/immutable UDF #1038

merged 1 commit into from
Sep 7, 2023

Conversation

sfc-gh-tbao
Copy link
Contributor

@sfc-gh-tbao sfc-gh-tbao commented Sep 5, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-903916

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

This PR adds keyword support for volatile/immutable when registering Snowpark UDFs.

@sfc-gh-tbao sfc-gh-tbao requested a review from a team as a code owner September 5, 2023 18:56
@github-actions
Copy link

github-actions bot commented Sep 5, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-tbao
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-tbao
Copy link
Contributor Author

recheck

@sfc-gh-stan
Copy link
Collaborator

The changes LGTM. Please add an entry in CHANGELOG.md to document this addition.

sfc-gh-aling
sfc-gh-aling requested changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comments regarding the values of this field

@sfc-gh-aling sfc-gh-aling merged commit 55940b0 into main Sep 7, 2023
@sfc-gh-aling sfc-gh-aling deleted the tbao_snowpark_dev branch September 7, 2023 23:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam left review comments

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-sfan sfc-gh-sfan Awaiting requested review from sfc-gh-sfan sfc-gh-sfan was automatically assigned from snowflakedb/snowpark-python-api

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-tbao @sfc-gh-stan @sfc-gh-aling @sfc-gh-aalam