Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-900244-Expose DataFrame._session and Session._session_id to users #1030

Merged
merged 6 commits into from
Sep 14, 2023
Merged

SNOW-900244-Expose DataFrame._session and Session._session_id to users #1030

merged 6 commits into from
Sep 14, 2023

Conversation

sfc-gh-yuwang
Copy link
Collaborator

No description provided.

@sfc-gh-yuwang
Copy link
Collaborator Author

should we let customer have access to session.connection? Because ServerConnection is a internal class and have no documentation on it, customer would see nothing with the hyperlink in docments

sfc-gh-yixie
sfc-gh-yixie requested changes Aug 29, 2023
View reviewed changes
src/snowflake/snowpark/session.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/dataframe.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/session.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/session.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-yixie
Copy link
Collaborator

Better add some mock unit tests.

@sfc-gh-yuwang
Copy link
Collaborator Author

Better add some mock unit tests.

should I add test under tests/unit/test_session.py and tests/unit/test_dataframe.py? I didn't see other test for properties in the repo

@sfc-gh-yuwang sfc-gh-yuwang marked this pull request as ready for review September 11, 2023 16:20
@sfc-gh-yuwang sfc-gh-yuwang requested a review from a team as a code owner September 11, 2023 16:20
sfc-gh-sfan
sfc-gh-sfan reviewed Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-sfan sfc-gh-sfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the PR title more descriptive.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-yuwang sfc-gh-yuwang changed the title SNOW-900244 SNOW-900244-Expose DataFrame._session and Session._session_id to users Sep 11, 2023
sfc-gh-mabrennan
sfc-gh-mabrennan reviewed Sep 12, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
sfc-gh-mabrennan
sfc-gh-mabrennan reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-mabrennan sfc-gh-mabrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstrings look good. I just had a few suggestions. Thanks!

@sfc-gh-yuwang sfc-gh-yuwang merged commit a24cbf0 into main Sep 14, 2023
50 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the SNOW-900244 branch September 14, 2023 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan left review comments

@sfc-gh-mabrennan sfc-gh-mabrennan sfc-gh-mabrennan left review comments

@sfc-gh-yixie sfc-gh-yixie sfc-gh-yixie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-yuwang @sfc-gh-yixie @sfc-gh-mabrennan @sfc-gh-sfan