From f488c48464184db5ac330a2a3110b91de34d77b8 Mon Sep 17 00:00:00 2001 From: Sophie Tan Date: Wed, 12 Jun 2024 14:23:28 -0700 Subject: [PATCH] Address comments --- CHANGELOG.md | 6 +++--- tests/mock/test_column.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d9423ed8c04..85579f06943 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,9 +22,9 @@ - Fixed a bug in convert_timezone that made the setting the source_timezone parameter return an error. - Fixed a bug where creating DataFrame with empty data of type `DateType` raises `AttributeError`. - Fixed a bug that table merge fails when update clause exists but no update takes place. -- Fixed a bug in mock implementation of `to_char` that raises `IndexError` when incoming column has inconsecutive row index. -- Fixed a bug in handling of `CaseExpr` expressions that raises `IndexError` when incoming column has inconsecutive row index. -- Fixed a bug in implementation of `Column.like` that raises `IndexError` when incoming column has inconsecutive row index. +- Fixed a bug in mock implementation of `to_char` that raises `IndexError` when incoming column has nonconsecutive row index. +- Fixed a bug in handling of `CaseExpr` expressions that raises `IndexError` when incoming column has nonconsecutive row index. +- Fixed a bug in implementation of `Column.like` that raises `IndexError` when incoming column has nonconsecutive row index. ### Snowpark pandas API Updates diff --git a/tests/mock/test_column.py b/tests/mock/test_column.py index ee9ec5c9885..9a2e27f37ef 100644 --- a/tests/mock/test_column.py +++ b/tests/mock/test_column.py @@ -13,7 +13,7 @@ def test_casewhen_with_non_zero_row_index(session): ).collect() == [Row(A=7)] -def test_regexp_with_non_zero_row_index(session): +def test_like_with_non_zero_row_index(session): df = session.create_dataframe([["1", 2], ["3", 4]], schema=["a", "b"]) assert df.filter(col("b") > 2).select( col("a").like("1").alias("res")