From 7c8944383985dd1175dfc9a0742de9a412d388a5 Mon Sep 17 00:00:00 2001 From: Yun Zou Date: Tue, 17 Sep 2024 12:23:31 -0700 Subject: [PATCH] address feedback --- src/snowflake/snowpark/modin/plugin/_internal/utils.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/snowflake/snowpark/modin/plugin/_internal/utils.py b/src/snowflake/snowpark/modin/plugin/_internal/utils.py index 57538d3513b..751879d3dfc 100644 --- a/src/snowflake/snowpark/modin/plugin/_internal/utils.py +++ b/src/snowflake/snowpark/modin/plugin/_internal/utils.py @@ -285,7 +285,6 @@ def _create_read_only_table( else STATEMENT_PARAMS.UNKNOWN, } statement_params.update(new_params) - # TODO: use snowpark save_as_table when user facing scoped object is supported session.sql( f"CREATE OR REPLACE {get_temp_type_for_object(use_scoped_temp_objects=use_scoped_temp_table, is_generated=True)} TABLE {temp_table_name} AS {ctas_query}" ).collect(statement_params=statement_params) @@ -300,7 +299,7 @@ def _create_read_only_table( STATEMENT_PARAMS.READONLY_TABLE_NAME: readonly_table_name, } ) - # TODO: pushing read only table creation down to snowpark for general usage + # TODO (SNOW-1669224): pushing read only table creation down to snowpark for general usage session.sql( f"CREATE OR REPLACE {get_temp_type_for_object(use_scoped_temp_objects=use_scoped_temp_table, is_generated=True)} READ ONLY TABLE {readonly_table_name} CLONE {table_name}" ).collect(statement_params=statement_params)