-
Notifications
You must be signed in to change notification settings - Fork 116
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SNOW-1658008: Clean up Snowpark pandas documentation references (#2255)
<!--- Please answer these questions before creating your pull request. Thanks! ---> 1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR. <!--- In this section, please add a Snowflake Jira issue number. Note that if a corresponding GitHub issue exists, you should still include the Snowflake Jira issue number. For example, for GitHub issue #1400, you should add "SNOW-1335071" here. ---> Fixes SNOW-1658008 2. Fill out the following pre-review checklist: - [ ] I am adding a new automated test(s) to verify correctness of my new code - [ ] If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing - [ ] I am adding new logging messages - [ ] I am adding a new telemetry message - [ ] I am adding new credentials - [ ] I am adding a new dependency - [ ] If this is a new feature/behavior, I'm adding the Local Testing parity changes. 3. Please describe how your code solves the related issue. This PR updates type annotation and documentation paths referencing Snowpark pandas objects. Notably, `snowflake.snowpark.modin.pandas.Series`/`DataFrame` are now referenced by `modin.pandas.Series`/`DataFrame`. In Snowpark session + DataFrame objects: functions that reference Snowpark pandas objects now refer to `modin.pandas`, with the import guarded by the `TYPE_CHECKING` variable. This should not affect any Snowpark non-pandas users. In Snowpark pandas, references to `snowflake.snowpark.modin.pandas.io.*` were not generating correctly; these have been edited to `snowflake.snowpark.modin.pandas.*`. Removing the `snowflake.snowpark` prefix from these does not currently work; I will investigate why after GA.
- Loading branch information
1 parent
5358ee3
commit 2eb2a2a
Showing
17 changed files
with
171 additions
and
158 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ Input/Output | |
:toctree: pandas_api/ | ||
|
||
read_snowflake | ||
to_snowflake | ||
to_snowpark | ||
|
||
.. rubric:: pandas | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.