Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1843517: Double the amount of queries executed during table reflection in update 1.7.0 #554

Open
phillip-parrott opened this issue Dec 3, 2024 · 3 comments · Fixed by #556
Open

SNOW-1843517: Double the amount of queries executed during table reflection in update 1.7.0 #554

phillip-parrott opened this issue Dec 3, 2024 · 3 comments · Fixed by #556
Assignees
@sfc-gh-jvasquezrojas
Labels
bug Something isn't working status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@phillip-parrott
Copy link
Contributor

Please answer these questions before submitting your issue. Thanks!

  1. What version of Python are you using?

    3.11.8

  2. What operating system and processor architecture are you using?

    Linux

  3. What are the component versions in the environment (pip freeze)?

    snowflake-sqlalchemy = "1.7.0"

  4. What did you do?

    After the latest update to 1.7.0, we began seeing double the number of queries for each reflection. We believe it is due to the get_multi_prefixes function in snowdialect.py.

  5. What did you expect to see?

    We would expect no changes, but this doubled reflection time. For small amounts of tables this isn't an issue, but we have a big project where we are reflecting hundreds of tables.
@phillip-parrott phillip-parrott added bug Something isn't working needs triage labels Dec 3, 2024
@github-actions github-actions bot changed the title Double the amount of queries executed during table reflection in update 1.7.0 SNOW-1843517: Double the amount of queries executed during table reflection in update 1.7.0 Dec 3, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed needs triage labels Dec 3, 2024
@sfc-gh-dszmolka
Copy link
Contributor

hi - thank you for reporting (and also see an official Support Case 00904441 has been created, too) , we'll take a look.

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas linked a pull request Dec 5, 2024 that will close this issue
Improve index reflection #556
Merged
4 tasks
@sfc-gh-dszmolka
Copy link
Contributor

PR #556 should fix this, under review.

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-pr_pending_merge A PR is made and is under review label Dec 9, 2024
@sfc-gh-dszmolka
Copy link
Contributor

change seems to be merged, which autoclosed this issue. Reopening to be able to keep track with the release.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas

Labels
bug Something isn't working status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve index reflection snowflakedb/snowflake-sqlalchemy
3 participants
@sfc-gh-dszmolka @phillip-parrott @sfc-gh-jvasquezrojas