Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1348391: Unable to use query_tag in Snowflake-SQLAlchemy #495

Open
NehaNRane opened this issue Apr 26, 2024 · 3 comments · May be fixed by #496
Open

SNOW-1348391: Unable to use query_tag in Snowflake-SQLAlchemy #495

NehaNRane opened this issue Apr 26, 2024 · 3 comments · May be fixed by #496
Labels
feature status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team

Comments

@NehaNRane
Copy link

What is the current behavior?

Currently, the Snowflake-SQLAlchemy library does not support the query_tag parameter when executing queries against Snowflake. The query_tag parameter allows users to attach custom metadata to their queries, facilitating query identification, resource management, and performance optimization within the Snowflake environment.

Reasons for Using query_tag:

  1. Query Identification: With query_tag, users can label their queries with custom metadata, making it easier to identify and categorize queries within Snowflake's query history and performance monitoring tools.
  2. Resource Management: By associating queries with specific application components or business processes, users can track resource consumption and allocate resources more effectively.
  3. Performance Optimization: query_tag enables users to analyze query performance based on custom criteria, such as application version, user role, or geographic location, leading to more targeted optimization efforts.

What is the desired behavior?

Users should be able to include the query_tag in session_parameter in their SQLAlchemy queries when connecting to Snowflake, with the specified tag being propagated to Snowflake and associated with the corresponding query execution.

How would this improve snowflake-connector-python?

Add support for the query_tag in session_parameter in the Snowflake-SQLAlchemy library, allowing users to specify custom query tags when executing queries. This enhancement will provide users with greater flexibility and control over query metadata, improving query management and performance monitoring capabilities.

The addition of query_tag support in Snowflake-SQLAlchemy will align the library more closely with Snowflake's capabilities and best practices, enhancing the overall user experience and enabling more sophisticated query management strategies.

References, Other Background

#266
@github-actions github-actions bot changed the title Unable to use query_tag in Snowflake-SQLAlchemy SNOW-1348391: Unable to use query_tag in Snowflake-SQLAlchemy Apr 26, 2024
@NehaNRane NehaNRane linked a pull request Apr 26, 2024 that will close this issue
Open
4 tasks
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage_done Initial triage done, will be further handled by the driver team label Apr 29, 2024
@sfc-gh-dszmolka
Copy link
Contributor

hey - thank you for raising this and especially for the PR , really appreciated! we'll review

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-pr_pending_merge A PR is made and is under review label May 1, 2024
@NehaNRane
Copy link
Author

@sfc-gh-dszmolka Any update on the PR.

@sfc-gh-dszmolka
Copy link
Contributor

unfortunately i don't have any update, but perhaps pinging the PR could get some

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

accepting query_tag as session_parameters in connection arguments NehaNRane/snowflake-sqlalchemy
2 participants
@sfc-gh-dszmolka @NehaNRane