Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "PROD-39429 Add parameter for connector name in channel name a… #736

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Revert "PROD-39429 Add parameter for connector name in channel name a… #736

merged 1 commit into from
Oct 26, 2023

Conversation

sfc-gh-japatel
Copy link
Collaborator

…nd revert the behavior: (#732)"

This reverts commit feaa491.

Description

This is PART-1 for our long term commit.

  1. We dont want any more configs. Especially for those on 2.1.0 and want to upgrade.
  2. This is a revert of config added here feaa491
  3. This commit doesn't revert the original commit yet. i.e We still have new channel name.

What next

We have few more PR left:

  1. Next PR will have a REST API logic for checking if Channel Exists in a table or not.
  2. Actual algorithm for seamless transition from new channel to old channel.
  3. We will have a PR separately for customers to add a suffix to channel name. But this risk is upto them.

@sfc-gh-japatel sfc-gh-japatel merged commit 706a93d into master Oct 26, 2023
30 checks passed
@sfc-gh-japatel sfc-gh-japatel deleted the japatel-PROD-39429-revert-param-name branch October 26, 2023 17:40
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Dec 4, 2023
@sfc-gh-japatel @khsoneji
Revert "PROD-39429 Add parameter for connector name in channel name a… (
dd75f05 
snowflakedb#736)
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Dec 4, 2023
@sfc-gh-japatel @khsoneji
Revert "PROD-39429 Add parameter for connector name in channel name a… (
c0c372e 
snowflakedb#736)
khsoneji pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Dec 4, 2023
@sfc-gh-japatel @khsoneji
Revert "PROD-39429 Add parameter for connector name in channel name a… (
eeb0c40 
snowflakedb#736)
EduardHantig pushed a commit to streamkap-com/snowflake-kafka-connector that referenced this pull request Feb 1, 2024
@sfc-gh-japatel @EduardHantig
Revert "PROD-39429 Add parameter for connector name in channel name a… (
cf55625 
snowflakedb#736)
sudeshwasnik pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Feb 16, 2024
@sfc-gh-japatel @sudeshwasnik
Revert "PROD-39429 Add parameter for connector name in channel name a… (
df42e0a 
snowflakedb#736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-rcheng sfc-gh-rcheng sfc-gh-rcheng approved these changes

@sfc-gh-tzhang sfc-gh-tzhang sfc-gh-tzhang approved these changes

@sfc-gh-tjones sfc-gh-tjones Awaiting requested review from sfc-gh-tjones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-japatel @sfc-gh-tzhang @sfc-gh-rcheng