Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1761519 Fix empty arrays in Iceberg ingestion #1003

Merged
merged 1 commit into from
Nov 20, 2024
Merged

SNOW-1761519 Fix empty arrays in Iceberg ingestion #1003

merged 1 commit into from
Nov 20, 2024
+2 −2

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Nov 19, 2024 •
edited
Loading

Overview

SNOW-1761519

This bug was discovered at the beginning of work with Iceberg ingestion. I validated locally with the most recent ingest sdk that it passes.

The test will be enabled after ingest sdk 3.0.1 release.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner November 19, 2024 14:50
@sfc-gh-mbobowski sfc-gh-mbobowski merged commit c3273c1 into master Nov 20, 2024
51 of 52 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-SNOW-1761519-empty-arrays branch November 20, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-rsawicki sfc-gh-rsawicki sfc-gh-rsawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mbobowski @sfc-gh-rsawicki