From 27e973f1cf9295591c833f3fb467ecfd4d996bff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Z=C4=85bek?= Date: Tue, 12 Nov 2024 15:55:27 +0100 Subject: [PATCH] format and improve comment --- .../internal/streaming/DirectStreamingClientHandler.java | 3 +-- .../internal/streaming/StreamingClientProperties.java | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/snowflake/kafka/connector/internal/streaming/DirectStreamingClientHandler.java b/src/main/java/com/snowflake/kafka/connector/internal/streaming/DirectStreamingClientHandler.java index c3c7239d1..c9c97f994 100644 --- a/src/main/java/com/snowflake/kafka/connector/internal/streaming/DirectStreamingClientHandler.java +++ b/src/main/java/com/snowflake/kafka/connector/internal/streaming/DirectStreamingClientHandler.java @@ -46,8 +46,7 @@ public SnowflakeStreamingIngestClient createClient( SnowflakeStreamingIngestClientFactory.builder( streamingClientProperties.clientName + "_" + createdClientId.getAndIncrement()) .setProperties(streamingClientProperties.clientProperties) - .setParameterOverrides(streamingClientProperties.parameterOverrides) - ; + .setParameterOverrides(streamingClientProperties.parameterOverrides); SnowflakeStreamingIngestClient createdClient = builder.build(); diff --git a/src/main/java/com/snowflake/kafka/connector/internal/streaming/StreamingClientProperties.java b/src/main/java/com/snowflake/kafka/connector/internal/streaming/StreamingClientProperties.java index f82b9add4..393791331 100644 --- a/src/main/java/com/snowflake/kafka/connector/internal/streaming/StreamingClientProperties.java +++ b/src/main/java/com/snowflake/kafka/connector/internal/streaming/StreamingClientProperties.java @@ -91,7 +91,8 @@ public StreamingClientProperties(Map connectorConfig) { // Override only if the streaming client properties are explicitly set in config this.parameterOverrides = new HashMap<>(); if (isIcebergEnabled) { - // todo extract to field + // TODO should be replaced by SnowflakeStreamingIngestClientFactory.builder.setIceberg(true) + // call in SNOW-1728002 this.parameterOverrides.put("enable_iceberg_streaming", "true"); } Optional snowpipeStreamingMaxClientLag =