From 205f928cf89357e301f7ceb621a6c77ec0ca5843 Mon Sep 17 00:00:00 2001 From: Wojciech Trefon Date: Tue, 15 Oct 2024 13:16:42 +0200 Subject: [PATCH] Add todos --- .../internal/streaming/DirectStreamingClientHandler.java | 1 + .../com/snowflake/kafka/connector/records/RecordService.java | 1 + 2 files changed, 2 insertions(+) diff --git a/src/main/java/com/snowflake/kafka/connector/internal/streaming/DirectStreamingClientHandler.java b/src/main/java/com/snowflake/kafka/connector/internal/streaming/DirectStreamingClientHandler.java index eac549b42..f86574c4b 100644 --- a/src/main/java/com/snowflake/kafka/connector/internal/streaming/DirectStreamingClientHandler.java +++ b/src/main/java/com/snowflake/kafka/connector/internal/streaming/DirectStreamingClientHandler.java @@ -67,6 +67,7 @@ public SnowflakeStreamingIngestClient createClient( private static void enableIceberg(SnowflakeStreamingIngestClientFactory.Builder builder) { try { + // TODO reflection should be replaced by proper builder.setIceberg(true) call in SNOW-1728002 FieldUtils.writeField(builder, "isIceberg", true, true); } catch (IllegalAccessException e) { throw new IllegalStateException( diff --git a/src/main/java/com/snowflake/kafka/connector/records/RecordService.java b/src/main/java/com/snowflake/kafka/connector/records/RecordService.java index 7430ad051..16a8b5f47 100644 --- a/src/main/java/com/snowflake/kafka/connector/records/RecordService.java +++ b/src/main/java/com/snowflake/kafka/connector/records/RecordService.java @@ -277,6 +277,7 @@ private Map processSnowflakeRecord(SnowflakeTableRow row) private Map processIcebergRecord(SnowflakeTableRow row) throws JsonProcessingException { + // TODO this not cover all cases, full implementation will be done in SNOW-1737840 final Map streamingIngestRow = new HashMap<>(); for (JsonNode node : row.content.getData()) { if (enableSchematization) {