Snow 1814745 fix aborting requests in http client #967
+153
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Added logs for node.js http client. Renamed utils file to comply with convention.
…bles. Fixed comments styling.
…est logic. Unified request and request async
sfc-gh-fpawlowski
changed the base branch from
master
to
SNOW-1631790-Transport-Layer
lib/http/base.js
Outdated
| let sendRequest = async function sendRequest() { | ||
| Logger.getInstance().trace('Request%s - sending.', requestUtil.describeRequestFromOptions(requestOptions)); | ||
| const timer = new ExecutionTimer().start(); | ||
| requestPromise = axios.request(requestOptions).then(response => { | ||
| requestPromise = axios.request(requestOptions, { signal: requestController }).then(response => { |
There was a problem hiding this comment.
Let's move this to a separate object - e.g. requestHandlers
…t using connection config added.
…ters describing token prefixing it fixed.
…rting-requests-in-HttpClient
sfc-gh-pmotacki
force-pushed
the
SNOW-1631790-Transport-Layer
branch
from
adb13c4 to
6c27246
Compare
… added. Test for normalizing the response added.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #967 +/- ##
==========================================
+ Coverage 88.92% 89.07% +0.15%
==========================================
Files 72 72
Lines 6950 6955 +5
==========================================
+ Hits 6180 6195 +15
+ Misses 770 760 -10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist
npm run lint:check -- CHANGED_FILESand fix problems in changed code)npm run test:unitandnpm run test:integration)