Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1730434 libcurl 8.10.1 upgrade #761

Merged
merged 5 commits into from
Oct 24, 2024
Merged

SNOW-1730434 libcurl 8.10.1 upgrade #761

merged 5 commits into from
Oct 24, 2024

Conversation

sfc-gh-jszczerbinski
Copy link
Contributor

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski commented Oct 23, 2024 •
edited
Loading

Upgrading curl to version 8.10.1 from https://curl.se/download/.

Procedure:

  1. Download old version (8.7.1), create diff between version 8.7.1 and curl in our repo
  2. Remove old version and commit
  3. Download new version (8.10.1) and commit it in our repo.
  4. Apply the patch to the new version, apply fixes and commit changes.
  5. Update build scripts and commit changes.

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski requested a review from a team as a code owner October 23, 2024 11:46
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1730434-libcurl-8-10-1-upgrade branch 3 times, most recently from cf3ef1d to 59b1774 Compare October 23, 2024 12:45
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski mentioned this pull request Oct 23, 2024
Merged
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1730434-libcurl-8-10-1-upgrade branch from 1681c0f to 3559c90 Compare October 23, 2024 17:40
@sfc-gh-ext-simba-hx
Copy link
Collaborator

Please remove deps/curl-8.10.1/docs/HTTP3.md, that one triggered synk issue before.

sfc-gh-ext-simba-hx
sfc-gh-ext-simba-hx approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the HTTP3.md one others LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1730434-libcurl-8-10-1-upgrade branch from 3559c90 to 3e71dac Compare October 24, 2024 05:40
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessary files and use curl as a dependency directory

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1730434-libcurl-8-10-1-upgrade branch from 3e71dac to 946fb6c Compare October 24, 2024 07:43
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1730434-libcurl-8-10-1-upgrade branch from 946fb6c to c894a59 Compare October 24, 2024 08:05
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1730434-libcurl-8-10-1-upgrade branch from c894a59 to 9100f8a Compare October 24, 2024 08:12
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski merged commit 442899b into master Oct 24, 2024
43 checks passed
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski deleted the SNOW-1730434-libcurl-8-10-1-upgrade branch October 24, 2024 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-dstempniak sfc-gh-dstempniak Awaiting requested review from sfc-gh-dstempniak

@sfc-gh-mkubik sfc-gh-mkubik Awaiting requested review from sfc-gh-mkubik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jszczerbinski @sfc-gh-ext-simba-hx @sfc-gh-dprzybysz