Revert "SNOW-1730434 curl upgrade 8.10.1 (#758)" #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dd76ce4.
sfc-gh-jszczerbinski
requested review from
sfc-gh-ext-simba-hx and
sfc-gh-dprzybysz
|
Can we get the 4 files removed instead of entirely reverting the curl update? |
|
I disagree. It blocks all commits from branches based on master (due to collisions secret detection fails). |
sfc-gh-mkubik
approved these changes
Oct 23, 2024
sfc-gh-dheyman
approved these changes
Oct 23, 2024
|
@sfc-gh-ext-simba-hx Can you make you redo the PR. Please remove all the files from the old curl version in the new PR. |
|
Seems like we want to have this in the next release. New PR already in progress: #761 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit dd76ce4.
Curl update was incorrectly performed, not all files from old curl version were deleted. This caused conflicts between files in the repo on case-insensitive filesystems. Following files are remains of the old curl version and cause collision: