Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save diskspace on git #567

Merged
3 commits merged into from
Oct 7, 2023
Merged

save diskspace on git #567

3 commits merged into from
Oct 7, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2023

Seems github reduced the diskspace for it's runners the debug build on Linux start to fail.
Remove some unnecessary files to save disk space.
The zip files was a pre-build version of arrow. Since currently we build arrow from source code on all platforms it's no use anymore. Anyone needs pre-build artifacts of arrow should get that from s3, like what ODBC is doing currently.
files in deps is not used after all dependencies building finished. The artifacts are in deps-build so deps can be deleted to save some space.

@ghost ghost self-requested a review as a code owner October 6, 2023 20:04
@sfc-gh-igarish
Copy link
Collaborator

If you remove it, make sure nobody references it. If it's find alternate way to access it.

@ghost
Copy link
Author

ghost commented Oct 6, 2023

If you remove it, make sure nobody references it. If it's find alternate way to access it.

Sure, it should be fine if the test passes.
The zip files was a pre-build version of arrow. Since currently we build arrow from source code on all platforms it's no use anymore.
files in deps is not used after all dependencies building finished. The artifacts are in deps-build so deps can be deleted to save some space.

@ghost ghost requested a review from sfc-gh-igarish October 6, 2023 21:32
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit db36419 into master Oct 7, 2023
23 checks passed
@ghost ghost deleted the save-diskspace-on-git branch October 7, 2023 16:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants