Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-918603: Fix the test failures we commented out recently #564

Merged
1 commit merged into from
Oct 25, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 26, 2023

related SDK issue: 658, 340

It's a potential bug that made 3 years ago #207 .
Worked fine until we got some unit test case hang recently.
Has been there for a long time and no customer report so far likely not a customer facing issue.

@ghost ghost self-requested a review as a code owner September 26, 2023 18:15
@ghost ghost requested review from sfc-gh-kdama and sfc-gh-igarish September 26, 2023 18:16
@ghost
Copy link
Author

ghost commented Sep 26, 2023

@sfc-gh-kdama Please help to verify it works on Jenkins, both Linux aarch64 and Linux x86_64. No rush though as we should have enough time to do that before October release.

@ghost ghost force-pushed the SNOW-918603-test-hang-on-jenkins branch from 6a90e4c to fea4553 Compare October 7, 2023 16:49
@ghost ghost force-pushed the SNOW-918603-test-hang-on-jenkins branch from fea4553 to e2018e3 Compare October 17, 2023 00:55
@sfc-gh-kdama
Copy link
Contributor

I see the build jobs are working fine for all platforms.

@ghost
Copy link
Author

ghost commented Oct 23, 2023

Thanks @sfc-gh-kdama for the confirmation.

Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost force-pushed the SNOW-918603-test-hang-on-jenkins branch from e2018e3 to cadb1a6 Compare October 25, 2023 02:15
@ghost ghost merged commit 1eeb907 into master Oct 25, 2023
23 checks passed
@ghost ghost deleted the SNOW-918603-test-hang-on-jenkins branch October 25, 2023 14:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants