-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async-callback should not be invoked for filtered out items #340
Comments
Actually, there is little value in fixing this because one of the points of creating the lorax project with its intended reactive model, is to simplify the initialisation sequence of extendio's navigator. The proper fix to this is the reactive model which will make this all much easier. For now, there is the problem of the filtering only applying after the async, which is too late and there isn't a quick workaround. I did think that inserting the async callback before the filter is initialised, but that would not work as it would require storing the context inside a struct, which I'm trying to avoid at all costs (I would rather build the entire required reactive model than take that route). As a reminder to oneself, the intention is to create a sequence something like:
or
or
or
For the purposes of resume, all options would have to be collected and restored. In the above, the options specified in new, do not include information relating to filters or listen as they are passed into those operators directly. One thing that was discovered was that LabelledTraverseCallback was being referenced by value rather than be pointer, so this has been fixed. |
ensync BEFORE: raw: filter AFTER: PROXY: frame.raw: filter INSIDE BOOST: this is being caused by the bad decision to use the raw pointer; this is confusing everything and making the code brittle and hard to work with WORKER: |
The async wrapper is not decorating in the correct position, so it sees items that will be filtered out. This is inefficient and should be avoided.
The text was updated successfully, but these errors were encountered: