Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate values created by fillChromPeaks #750

Open
frankyWk opened this issue May 30, 2024 · 1 comment
Open

Duplicate values created by fillChromPeaks #750

frankyWk opened this issue May 30, 2024 · 1 comment

Comments

@frankyWk
Copy link

Our workflow is findChromPeaks, groupChromPeaks and fillChromPeaks. I am finding duplicate values in the output from fillChromPeaks - I have attached a sample file.
Is this expected behaviour where peaks are e.g. <1ppm apart and default FillChromPeaksParam() values are used?
3_peaks_after_filling_missing.csv

@jorainer
Copy link
Collaborator

jorainer commented Jun 3, 2024

fillChromPeaks() is only integrating values for features for which a chrom peak was missing in one or more files. So, it depends on the features that were defined. If you have features with less than 1 ppm apart then the function will integrate values for this. I guess you might have to check the settings for the groupChromPeaks() again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants