Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypted fields need a buttonLabel #201

Open
lfeigen opened this issue Aug 28, 2023 · 2 comments
Open

Encrypted fields need a buttonLabel #201

lfeigen opened this issue Aug 28, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@lfeigen
Copy link

lfeigen commented Aug 28, 2023

Is your feature request related to a problem? Please describe.
We internationalize all of the strings in our UI using labels and we can't do that for the "CHANGE" button for encrypted fields.

Describe the solution you'd like
Seems simple enough to just add a buttonLabel

Describe alternatives you've considered
For now, we are just living with this one button being in English.

@lfeigen lfeigen added the enhancement New feature or request label Aug 28, 2023
@pvrobays
Copy link
Collaborator

pvrobays commented Sep 6, 2023

Hi @lfeigen

Thanks for your issue.

If I'm understanding correctly you're using the secret input field?
It's indeed true that most of the labels are adaptable except the ones from the secret input field.
Not only the 'Change' button, but also the dialog labels should be adaptable then if I'm understanding correctly?

When I have the some free time, I'll add the labels or - it this is a pressing issue - you can of course contribute and leave a PR.

@lfeigen
Copy link
Author

lfeigen commented Sep 6, 2023

I hope to be able to contribute changes on one or more of these issues I've raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants