Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation error of GATConv #49

Open
linfeng-du opened this issue Jan 25, 2022 · 0 comments
Open

Implementation error of GATConv #49

linfeng-du opened this issue Jan 25, 2022 · 0 comments

Comments

@linfeng-du
Copy link

The message function of GATConv in chem/model.py writes
image
However, I think the alpha should be normalized w.r.t edge_index[1] (dst nodes) instead of edge_index[0] (src nodes) so that it is normalized among nodes connecting to a dst.

Although for undirected graphs, what calculated after scatter operations woule be the same, yet different indexing has different meaning (edge_index[0] and edge_index[1])

Consider this simple case, edge_index[1] gives the desired result
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant