New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A possible mistake in computing TPS #50

Open

XiaLiPKU opened this issue Mar 30, 2022 · 1 comment

XiaLiPKU commented Mar 30, 2022

Hi, Aliaksandr. Your code is really nice.
However, I find a small mistake here from L118 to L120:

articulated-animation/modules/model.py

Line 118 in db2c213

distances = torch.abs(distances).sum(-1)

articulated-animation/modules/model.py

Line 120 in db2c213

result = distances ** 2

Shouldn't it be result = (distances ** 2).sum(-1)?
With which change, the code will be more consistent with:
https://github.com/tomasjakab/imm/blob/0fee6b24466a5657d66099694f98036c3279b245/imm/utils/tps_sampler.py#L138

The text was updated successfully, but these errors were encountered:

Author

XiaLiPKU commented Mar 30, 2022 •

edited

Loading

By the way, this also happens in other two of your repos:
https://github.com/AliaksandrSiarohin/first-order-model/blob/ca49071ce60051200f58f03a0e4e65e675a54e27/modules/model.py#L105
https://github.com/AliaksandrSiarohin/motion-cosegmentation/blob/571e26f04b8c40c5454a158b4b570e4ba034c856/modules/model.py#L96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment