Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get a new release published? #47

Open
livzr opened this issue Jul 13, 2022 · 8 comments
Open

Can we get a new release published? #47

livzr opened this issue Jul 13, 2022 · 8 comments

Comments

@livzr
Copy link

livzr commented Jul 13, 2022

On v1.5.0, the following is outputted when building with webpack:

(node:27433) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
        Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
        Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
(Use `node --trace-deprecation ...` to show where the warning was created)

I've spotted that this has been resolved, but there hasn't been a new release to capture these changes.

@sn-satyendra
Copy link
Owner

@lewisrichardson some manual checks are still in pending for this. That's why the release is pending. It should be done in few days.

@livzr
Copy link
Author

livzr commented Aug 1, 2022

Thanks @sn-satyendra. Any update?

@sn-satyendra
Copy link
Owner

@lewisrichardson published a beta release 2.0.0-beta.0 for now, until the further checks are done.

@livzr
Copy link
Author

livzr commented Aug 3, 2022

@sn-satyendra Thank you. This breaks my build though.

<--- Last few GCs --->

[7089:0x629e700]   219821 ms: Mark-sweep 2016.7 (2085.2) -> 2000.5 (2084.6) MB, 2354.9 / 0.0 ms  (average mu = 0.116, current mu = 0.030) allocation failure scavenge might not succeed
[7089:0x629e700]   222168 ms: Mark-sweep 2016.4 (2084.6) -> 2002.1 (2086.1) MB, 2253.7 / 0.0 ms  (average mu = 0.079, current mu = 0.040) allocation failure scavenge might not succeed


<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0xb0a860 node::Abort() [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
 2: 0xa1c193 node::FatalError(char const*, char const*) [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
 3: 0xcf9a6e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
 4: 0xcf9de7 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
 5: 0xeb1685  [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
 6: 0xeb2166  [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
 7: 0xec068e  [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
 8: 0xec10d0 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
 9: 0xec404e v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
10: 0xe8558a v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationType, v8::internal::AllocationOrigin) [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
11: 0x11fe2d6 v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
12: 0x15f2d39  [/opt/hostedtoolcache/node/16.16.0/x64/bin/node]
Aborted (core dumped)
error Command failed with exit code 134.

@sn-satyendra
Copy link
Owner

@lewisrichardson can you provide more details:

  • webpack configuration
  • does this happen in production build or dev build (btw with 2.0.0 preloading support is not there for dev build)

@davelovemartin
Copy link

Any update on this?

@johnnyreilly
Copy link

johnnyreilly commented Oct 31, 2022

It looks like the beta build isn't working. Just doesn't seem to have any effect when running in dev build - the <link tags don't appear. Oh wait - it's not supported for dev. Let me try production.

@johnnyreilly
Copy link

johnnyreilly commented Oct 31, 2022

Production errors out like this with webpack 5.74.0:

<--- Last few GCs --->

[5470:0x5f21020]   193688 ms: Mark-sweep 2014.2 (2083.1) -> 1999.6 (2084.6) MB, 1393.2 / 0.1 ms  (average mu = 0.186, current mu = 0.049) allocation failure scavenge might not succeed
[5470:0x5f21020]   195149 ms: Mark-sweep 2015.4 (2084.6) -> 2001.1 (2085.9) MB, 1387.1 / 0.1 ms  (average mu = 0.124, current mu = 0.051) allocation failure scavenge might not succeed


<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0xb02930 node::Abort() [/home/john/.nvm/versions/node/v16.17.0/bin/node]
 2: 0xa18149 node::FatalError(char const*, char const*) [/home/john/.nvm/versions/node/v16.17.0/bin/node]
 3: 0xcdd16e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/home/john/.nvm/versions/node/v16.17.0/bin/node]
 4: 0xcdd4e7 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/home/john/.nvm/versions/node/v16.17.0/bin/node]
 5: 0xe94b55  [/home/john/.nvm/versions/node/v16.17.0/bin/node]
 6: 0xe95636  [/home/john/.nvm/versions/node/v16.17.0/bin/node]
 7: 0xea3b5e  [/home/john/.nvm/versions/node/v16.17.0/bin/node]
 8: 0xea45a0 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/home/john/.nvm/versions/node/v16.17.0/bin/node]
 9: 0xea751e v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/home/john/.nvm/versions/node/v16.17.0/bin/node]
10: 0xe68a5a v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationType, v8::internal::AllocationOrigin) [/home/john/.nvm/versions/node/v16.17.0/bin/node]
11: 0x11e17c6 v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [/home/john/.nvm/versions/node/v16.17.0/bin/node]
12: 0x15d5439  [/home/john/.nvm/versions/node/v16.17.0/bin/node]
Aborted (core dumped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants