Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency for shell mode #14

Open
OmarAshkar opened this issue Dec 24, 2022 · 4 comments · May be fixed by #15
Open

Inconsistency for shell mode #14

OmarAshkar opened this issue Dec 24, 2022 · 4 comments · May be fixed by #15

Comments

@OmarAshkar
Copy link

This plugin is awesome, but I want to write my snips in nvim, and convert to vscode and emacs. There is some descipancy that would need to change directory or file name.
vscode: shellscript
UltiSnips: sh
emacs: shell-script-mode, sh-script-mode, sh-mode, shell-mode

I think I need a workaround. Any help is appreciated!

@smjonas
Copy link
Owner

smjonas commented Dec 24, 2022

Hey thanks for creating this issue, I've actually been waiting for someone to run into this ;) I've created a PR and would appreciate if you could try it out.

For the YASnippet snippets, the plugin should now create a .yasnippet-parents file which includes all the other modes.

Of course, feel free to add more mappings (in the VSCode and yasnippet converter modules) if you have any!

@OmarAshkar
Copy link
Author

Your work is great. I am very new to lua, so I will take some time to look at it.

Thank you!

@smjonas
Copy link
Owner

smjonas commented Jan 16, 2023

Hey @OmarAshkar, just wanted to ask if you already had some time to look at this :) Btw I need to fix the tests in the PR first but otherwise I can just merge this as it is and improve it later (or when someone comes across it).

@OmarAshkar
Copy link
Author

Hi @smjonas. No unfortunately not yet :( . for now I keep the conversion as little as possible, then manually modify the location. I probably not have time till the end of this month .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants