Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 4.x Versions broken due to Animation and Skeleton Core Changes #32

Open
smix8 opened this issue Nov 4, 2021 · 7 comments
Open
Labels
bug Something isn't working change Changes for the better discussion Something to talk about

Comments

@smix8
Copy link
Owner

smix8 commented Nov 4, 2021

Both Godot 4.x versions are broken due to recent core changes made in Godot 4.x.

Animation data changed:

  • Animation Transform Tracks are removed
  • Replaced by new, dedicated Tracktypes for bone origin, basis and scale
  • and more ...

Skeleton changed:

  • Changed the bone rest calculation completely.
  • Skeleton bone positions are now imported in bone space
  • Bones are no longer relative to bone rest.
  • and more ...

Also a more official proposal for animation retargeting in Godot now exists by a core dev that superseded my proposal. This means addon development for the Godot 4.x is discontinued since there will be an official implementation.

@smix8 smix8 added bug Something isn't working discussion Something to talk about change Changes for the better labels Nov 4, 2021
@smix8 smix8 pinned this issue Apr 30, 2022
@ghost
Copy link

ghost commented May 17, 2022

Interesting that a core dev has gotten their change in, do you have any links to the PR or branch? I'm curious to see what it looks like... Have you tried it out yet?

@smix8
Copy link
Owner Author

smix8 commented May 17, 2022

@WiredDreamcaster
The first "official" implementation attempt was abandoned due to differences on details and is now back to the proposal stage.
I dont have a link rightnow but it was posted 7-10 days ago on the official godot-proposal repo.

@ghost
Copy link

ghost commented May 23, 2022

Hello @smix8, I haven't been able to find it just yet, was it under the discussions section? Do you remember any keywords that could help me search? So far not hitting anything for 'animation', 're/target', 'skeleton', or 'armature'. I didn't think it would be difficult to find. I will look further throughout the week.

@smix8
Copy link
Owner Author

smix8 commented May 23, 2022

It was named "Implement Retarget feature in the importer"

@hardmode1337
Copy link

@smix8 can I tease you to help me work on adding retargeting to my own engine?

@smix8
Copy link
Owner Author

smix8 commented Jun 12, 2022

@hardmode1337 Thanks for teasing me but I have to decline. I just don't have enough time, my backlog is already exploding ;)

@hardmode1337
Copy link

@hardmode1337 Thanks for teasing me but I have to decline. I just don't have enough time, my backlog is already exploding ;)

That's fine my friend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working change Changes for the better discussion Something to talk about
Projects
None yet
Development

No branches or pull requests

2 participants