Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Smithy IDLv 2.0 default trait #718

Closed
ianbotsf opened this issue Oct 13, 2022 · 5 comments
Closed

Add support for Smithy IDLv 2.0 default trait #718

ianbotsf opened this issue Oct 13, 2022 · 5 comments
Assignees

Comments

@ianbotsf
Copy link
Contributor

ianbotsf commented Oct 13, 2022

Add support for the defaultTrait.

  • In particular we may want to update our codegen constructs which are currently based on things like @boxed and primitive value types for figuring out defaults and nullability. We should revamp this to be much clearer and to align to IDL2 (example). This will require using the nullability index (possibly in more places than we do now).
  • @box trait was deprecated, update tests/codegen to use default trait instead
  • Implement presence tracking
@ianbotsf
Copy link
Contributor Author

Support Smithy IDL v2, including int enums, full nullability support via presence tracking, and any other new features available (requires investigation).

@ianbotsf ianbotsf changed the title Smithy 2.0 Smithy IDLv 2.0 Oct 13, 2022
@aajtodd
Copy link
Contributor

aajtodd commented Nov 17, 2022

@aajtodd
Copy link
Contributor

aajtodd commented Nov 22, 2022

Reviewing the changelog for Smithy we need look into:

@aajtodd aajtodd changed the title Smithy IDLv 2.0 Add support for Smithy IDLv 2.0 default trait Nov 29, 2022
@aajtodd
Copy link
Contributor

aajtodd commented Nov 29, 2022

I've split this catch all Smithy IDL v2 issue out into multiple issues (noted in comment above). I've left this issue dedicated to supporting the @default trait in Smithy IDL v2

@aajtodd
Copy link
Contributor

aajtodd commented Mar 29, 2023

UPDATE: Guidance has recently changed and presence tracking is no longer the recommendation

smithy-lang/smithy@609cb16

@lucix-aws lucix-aws self-assigned this Mar 31, 2023
@lucix-aws lucix-aws removed their assignment Apr 25, 2023
@ianbotsf ianbotsf assigned lauzadis and lucix-aws and unassigned lucix-aws May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants