Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbounded custom streams are not fully supported #621

Open
ianbotsf opened this issue Apr 5, 2022 · 2 comments
Open

Unbounded custom streams are not fully supported #621

ianbotsf opened this issue Apr 5, 2022 · 2 comments
Labels
bug This issue is a bug. no-auto-closure We do not want this issue to be automatically closed. p2 This is a standard priority issue

Comments

@ianbotsf
Copy link
Contributor

ianbotsf commented Apr 5, 2022

After the fix for #613 is in place, users will be able to provide custom/proxied streams but only when explicitly providing a non-null content length. There are seemingly-valid scenarios in which users may want to provide custom streams without an explicit content length, such as streaming from another source, building content on-the-fly, etc. We should come up with a way to support streams without an explicit content length, modify our stream type hierarchy to codify valid scenarios, improve error messaging to clarify expectations, or some combination thereof.

@aajtodd
Copy link
Contributor

aajtodd commented Apr 5, 2022

To add some additional context, I suspect this is less about how we have modeled the stream and more about how it is consumed in any given HTTP client engine implementation (e.g. conversion of null content-length to say transfer-encoding: chunked).

@aajtodd
Copy link
Contributor

aajtodd commented Jun 6, 2022

Also S3 requires Content-Length for PutObject and UploadPart (it should really be marked with requiresLength trait).

See aws/aws-sdk-net#1095 for relevant discussion around this limitation.

@ianbotsf ianbotsf added p2 This is a standard priority issue no-auto-closure We do not want this issue to be automatically closed. labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. no-auto-closure We do not want this issue to be automatically closed. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants