Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OkHttp4 Support Broken Due to Idle Connection PR #1176

Closed
1 task done
Rostifar opened this issue Nov 7, 2024 · 1 comment · Fixed by #1178
Closed
1 task done

OkHttp4 Support Broken Due to Idle Connection PR #1176

Rostifar opened this issue Nov 7, 2024 · 1 comment · Fixed by #1178
Labels
bug This issue is a bug. potential-regression Marking this issue as a potential regression to be checked by team member

Comments

@Rostifar
Copy link

Rostifar commented Nov 7, 2024

Describe the bug

A recent PR was merged, which requires ConnectionListener support to function correctly.

ConnectionListener was introduced in OkHttp 5.x, so this change will break OkHttp 4.x support.

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected behavior

Building an OkHttpEngine4 instance should not require any OkHttp 5.x concepts.

Current behavior

Instantiating OkHttpEngine4 will lead to a ClassNotFoundException exception for ConnectionListener when config.buildClient(...) is called.

Steps to Reproduce

Configure a OkHttp4Engine in accordance with these instructions:

import aws.smithy.kotlin.runtime.http.engine.okhttp4.OkHttp4Engine
val client = OkHttp4Engine()

Use http-client-engine-okhttp4 v1.3.20 to reproduce.

Possible Solution

No response

Context

No response

Smithy-Kotlin version

aws.smithy.kotlin:http-client-engine-okhttp4:1.3.20

Platform (JVM/JS/Native)

JVM

Operating system and version

Ubuntu 20.04

@Rostifar Rostifar added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 7, 2024
@github-actions github-actions bot added the potential-regression Marking this issue as a potential regression to be checked by team member label Nov 7, 2024
@Rostifar Rostifar changed the title OkHttp4 Support Broken due to Idle Connection Ml OkHttp4 Support Broken Due to Idle Connection PR Nov 7, 2024
@0marperez 0marperez removed the needs-triage This issue or PR still needs to be triaged. label Nov 11, 2024
@0marperez
Copy link
Contributor

Hello, thanks for reporting this issue. We have a PR up now that should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. potential-regression Marking this issue as a potential regression to be checked by team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants