-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While we enforcing the OkHttp Library in our Android app Location credential failing #1173
Comments
Related issue: awslabs/aws-sdk-kotlin#1411 Are you able to configure your application to use the standard OkHttp engine (not |
Yes, we are able configure the application to use the standard OkHttp Engine but Our daily integration tests are failing due to a transient dependency on the OkHttp library (v5.0.0-alpha.14) required by the AWS Library. Our integration test suite is essential for detecting potential issues introduced by new code changes. Previously, we were using the Google Places API, but since migrating to the AWS Location API, we’ve encountered this issue. |
Can you clarify, are you able to successfully use OkHttp v5.0.0-alpha.14 in the AWS SDK for Kotlin or not? Either way, if OkHttp4Engine is working for you, I see no issues with the usage of |
It is functioning correctly; however, the CI/CD pipeline is failing due to a version mismatch with the OKHttp MockWebServer, which is causing delays in releasing the production version. Additionally, our policy does not permit any libraries in production to use unstable versions, such as |
This is exactly the reason we've created I can't help you fix your CI/CD problems, if there is an SDK-specific issue please let me know, otherwise this issue will be closed soon. |
What I am referring is when enforce the OkHttp4Engine with the following configuration is still crashing:
Because it is expecting the |
Can you please provide a complete minimal reproduction of your issue? The exception you're seeing implies that the |
|
That is not a complete reproduction, it's missing a |
@lauzadis , |
Hello, I was able to reproduce the issue you're having. The root cause is that you're using the I'll reach out to the team which owns that project to see if they can introduce some configuration options so you can use OkHttp4. As a faster workaround I would recommend performing the Cognito authentication yourself with the OkHttp4-configured Kotlin SDK client rather than using this dependency. |
Hello, I believe I can help. We actually made a change recently that modifies the API of the location authentication SDK to to return the client configuration instead of a client, so if you update to use the latest version So your location authentication dependency would change to:
And your code implementation would change to:
Please let me know if you run into any issues with this. |
@cgalvan , If you want to reproduce by yourself.
|
We'll be closing this issue for now, let's track resolution in aws-geospatial/amazon-location-mobile-auth-sdk-android#17 since the issue is now isolated to that project. |
Describe the bug
Currently we are using the
aws.sdk.kotlin:location to 1.3.62
and working as expected if are enforcing the OkHttp libraryRegression Issue
Expected behavior
It supposed work with OKHttp4Engine
Current behavior
Steps to Reproduce
Code implementation
Possible Solution
By changing the gradle config as follows to use the okhttp-coroutine:5.0.0-alpha.14 :
I just remove the
exclude group: "com.squareup.okhttp3", module: "okhttp-coroutines"
Android app working as expected and my Dependency Graph looks like:
Context
I attempted to use
okhttp-coroutine
from version5.0.0-alpha.14
while enforcingOkhttp
version4.12.0
, and it worked successfully. However, I'm uncertain of any potential consequences.Smithy-Kotlin version
aws.sdk.kotlin:location :1.2.62
Platform (JVM/JS/Native)
JVM (Kotlin) JDK 17
Operating system and version
Android 13
The text was updated successfully, but these errors were encountered: