Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for netstandard2.1 #3

Open
dylanvdmerwe opened this issue Dec 19, 2019 · 3 comments
Open

Support for netstandard2.1 #3

dylanvdmerwe opened this issue Dec 19, 2019 · 3 comments

Comments

@dylanvdmerwe
Copy link

dylanvdmerwe commented Dec 19, 2019

Describe the bug
It would make sense to include this package in a class library so that it can be referenced from other parts of the application. However when trying to install in a netstandard2.1 project, the following error is given:
Package DocXToPdfConverter 1.0.3 is not compatible with netstandard2.1 (.NETStandard,Version=v2.0). Package DocXToPdfConverter 1.0.3 supports: netcoreapp2.1

Expected behavior
Is there any reason why this library requires netcoreapp2.1 and cannot support netstandard2.1?

I have found that you can do the following:

  • DocXToPdfConverter change TargetFramework to netstandard2.1. This requires no code changes.
  • ExampleApplication target netcoreapp3.1

And then everything will work. Your nuget package will then be a netstandard2.1 package to then be consumed in libraries.

The only reason for netstandard2.1 instead of the more generic netstandard2.0 is due to line 93 in ConvertWithLibreOffice.cs with ProcessStartInfo's ArgumentList. I'm sure there is away around this, but this was just a quick attempt to check compatibility.

@martinweihrauch
Copy link
Collaborator

Thank you for your suggestion! Unfortunately, we do not have the time to further look into it, but I'll just leave that here for anyone else, who is interested in using it for netstandard!
:)

@FabrizioPairone
Copy link

FabrizioPairone commented Feb 21, 2020

Hi! Today I found this awesome library that save me. I convert it to netstandard2.0 (because 2.1 are not supported by .netframework). I can send a merge request?

@Knight20102010
Copy link

Hello ,is possible to convert this projekct to .net framework 472? I was trying but didnt work, thanks for feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants