Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip stale report #331

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Skip stale report #331

wants to merge 6 commits into from

Conversation

asoliman92
Copy link
Contributor

No description provided.

@asoliman92 asoliman92 marked this pull request as ready for review November 27, 2024 18:45
@asoliman92 asoliman92 requested a review from a team as a code owner November 27, 2024 18:45
makramkd
makramkd reviewed Nov 27, 2024
View reviewed changes
commit/report.go Outdated
if err != nil {
return false, fmt.Errorf("get latest price seq nr: %w", err)
}
if seqNr < latestSeqNr {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check only makes sense for prices, lets just duplicate the exact check onchain

commit/report.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Metric CCIP-4399-stop-price-spam main
Coverage 74.1% 74.2%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd left review comments

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asoliman92 @makramkd