Skip to content

Commit

Permalink
CCIP-4472: Update default rate limit and cleanup comments (#1558)
Browse files Browse the repository at this point in the history
## Motivation
[CCIP-4472](https://smartcontract-it.atlassian.net/browse/CCIP-4472)

## Solution
  • Loading branch information
NourElRashidy authored and bukata-sa committed Dec 6, 2024
1 parent b925245 commit 7f2ba83
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions core/services/ocr2/plugins/ccip/tokendata/lbtc/lbtc.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"github.com/smartcontractkit/chainlink/v2/core/services/ocr2/plugins/ccip/tokendata/http"
)

// TODO: double check the validty of default values for lombard's API after checking docs
const (
apiVersion = "v1"
attestationPath = "deposits/getByHash"
Expand All @@ -35,8 +34,8 @@ const (
maxCoolDownDuration = 10 * time.Minute

// defaultRequestInterval defines the rate in requests per second that the attestation API can be called.
// this is set according to the APIs documentated 10 requests per second rate limit.
defaultRequestInterval = 100 * time.Millisecond
// this is set according to the APIs recommended 5 requests per second rate limit.
defaultRequestInterval = 200 * time.Millisecond

// APIIntervalRateLimitDisabled is a special value to disable the rate limiting.
APIIntervalRateLimitDisabled = -1
Expand Down Expand Up @@ -74,10 +73,9 @@ type TokenDataReader struct {
type messageAttestationResponse struct {
MessageHash string `json:"message_hash"`
Status attestationStatus `json:"status"`
Attestation string `json:"attestation"` // Attestation represented by abi.encode(payload, proof)
Attestation string `json:"attestation,omitempty"` // Attestation represented by abi.encode(payload, proof)
}

// TODO: Adjust after checking API docs
type attestationRequest struct {
PayloadHashes []string `json:"messageHash"`
}
Expand All @@ -86,8 +84,6 @@ type attestationResponse struct {
Attestations []messageAttestationResponse `json:"attestations"`
}

// TODO: Implement encoding/decoding

type sourceTokenData struct {
SourcePoolAddress []byte
DestTokenAddress []byte
Expand Down

0 comments on commit 7f2ba83

Please sign in to comment.