Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in two of KeyEncryptionAlgorithm ECDH-ES+* enums #737

Closed
sberyozkin opened this issue Oct 24, 2023 · 1 comment
Closed

Typos in two of KeyEncryptionAlgorithm ECDH-ES+* enums #737

sberyozkin opened this issue Oct 24, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@sberyozkin
Copy link
Contributor

https://github.com/smallrye/smallrye-jwt/blob/main/implementation/common/src/main/java/io/smallrye/jwt/algorithm/KeyEncryptionAlgorithm.java#L12C21-L12C29

has a typo in ECDH-ES+128KW and ECDH-ES+192KW in both cases, A is missing, correct is ECDH-ES+A128KW and ECDH-ES+A192KW.

ECDH-ES+A256KW enum is correct, using this family of elliptic curve algorithms for the encryption is rare compared to RSA-OAEP-* but ECDH-ES+A256KW is actually tested in https://github.com/smallrye/smallrye-jwt/blob/main/implementation/jwt-build/src/test/java/io/smallrye/jwt/build/JwtEncryptTest.java#L263

so it is a minor issue but needs to be fixed
@sberyozkin sberyozkin added the good first issue Good for newcomers label Oct 24, 2023
@Skyllarr Skyllarr mentioned this issue Oct 26, 2023
Closed
giotsintsadze added a commit to giotsintsadze/smallrye-jwt that referenced this issue Oct 27, 2023
@giotsintsadze
Fix typos in KeyEncryptionAlgorithm ECDH-ES+* enums (smallrye#737)
7cc8c83
sberyozkin pushed a commit that referenced this issue Oct 27, 2023
@giotsintsadze
Fix typos in KeyEncryptionAlgorithm ECDH-ES+* enums (#737) (#742)
04c4b35
@sberyozkin
Copy link
Contributor Author

Resolved by #742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sberyozkin