Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention hashing algorithm/command to check near hash & introduce more #5

Open
rugk opened this issue May 15, 2020 · 5 comments
Open
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@rugk
Copy link
Contributor

rugk commented May 15, 2020

The site should mention what hash algo it uses (looks like SHA-512) so one can check it locally.
Just saying "hash" means nothing – could also be an MD5 hash 😜

(Also SHA256 should be enough, but well… does not hurt.)

@rugk
Copy link
Contributor Author

rugk commented May 15, 2020

Ahhh it is BLAKE2b-512! 😮
No surprise the hashes don't match… #4 🙄

Really?
How am I supposed to check these locally. No Linux distro has a blake2 CLI hashing tool preinstalled… (and I also don't know how to install one)
Can't we have a more convenient hashes?

At least SHA-256 or so should be there…

BLAKE2b may be nice and fast, but really – who cares for hashing one file. We don't need an absurd performance here…

@rugk rugk changed the title Mention hashing algorithm/command to check near hash Mention hashing algorithm/command to check near hash & introduce more May 15, 2020
@aral
Copy link
Contributor

aral commented May 19, 2020

Even if it was a more popular hash, the problem is that no one* downloads and checks hashes anyway. Given that unless validation runs at install-time on the actual machine that it’s been installed on, we cannot protect against time-of-check-time-of-use attacks, my thought currently is to create a tiny commandline tool that can be used in place of wget or curl for this purpose.

* Except those three people in Iceland.

@aral aral added enhancement New feature or request documentation Improvements or additions to documentation labels May 19, 2020
@rugk
Copy link
Contributor Author

rugk commented May 19, 2020

Well… if no one does that anyway, why bother and display the hash on the website? If so, then just do remove that? 🤔 (What is the reason for displaying it there, then?)

@aral
Copy link
Contributor

aral commented May 19, 2020

So that people verifying it can copy and paste it like you did for your pull request ;)

@rugk
Copy link
Contributor Author

rugk commented May 20, 2020

Well… only for that…? 🤔
Edit: If you really think so, the hash could be de-emphasized a lot. No one needs it at the top of the site then, e.g. You could just have it labelled as an "internal file ID" (or "file hash") somewhere at the bottom.

(And yes, you caught me… 😜 🙃)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants