First cut at fixing publication bugs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichaels-harvard
approved these changes
Aug 12, 2023
| @@ -6,6 +6,12 @@ submitr | |||
| Change Log | |||
| ---------- | |||
|
|
|||
| 0.3.2 | |||
There was a problem hiding this comment.
I think we can/should remove the scripts/publish file as well, no?
There was a problem hiding this comment.
Yes, I guess so. I'm going to just disable it for now to make sure, but I traced through the call history and it seems GA is (quite indirectly) calling your script from dcicutils.
…nted to make things a bit more aesthetic.
|
I also changed around the way modules and submodules headings are done to be a little more aesthetic (better indentation and avoiding some spurious links to subcontent that is not there). |
|
The remaining changes are small so I'll just go ahead and merge. If anyone sees any issues with that, submit a bug report and I'll fix it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a
make buildnotmake configurebefore running the publication command. (The virtual env has to not just exist but actually contain the right libraries.)Note that I tested this by attaching a beta (0.3.1.1b0) tag, and the auto-publish worked to that in pypi, so I'm pretty confident this change works. (I've since then de-beta'd as 0.3.2 so this is ready to merge.)