Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodoc fixes #6

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Autodoc fixes #6

merged 2 commits into from
Aug 11, 2023

Conversation

netsettler
Copy link

  • This is slightly experimental but I don't know how to test it without just putting it up and it's broken now anyway, so hopefully it's all fine. It will make it deploy on tag, but what was broken was something about a missing "ref" argument, so I've changed "branches=master" to "ref=master". Hopefully that will help.

Also, the doc comes up with useless "Module Content" headings that don't actually ever have content so I'm removing those. You'd have to put stuff in __init__.py for those to be non-empty, and I have no taste for that.

tags:
- 'v*'
except:
- 'v*b*'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really not want to push betas automatically?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Practically, no matter what we might wish, the way this is written it's going to always autodoc master, so a tag on a PR on a branch would not end up having the doc from that branch processed.

But also I think if someone wants beta doc, they can ask for it manually. We rev betas a lot more often than we change doc and I fear it'd be clutter. Worst case, beta doc might appear before it was usable and really confuse people.

@netsettler netsettler merged commit ce8e1cc into master Aug 11, 2023
3 checks passed
@netsettler netsettler deleted the kmp_submitr_autodoc branch September 26, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants