Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MetricsQL (VictoriaMetrics version of PromQL) alongside PromQL #542

Open
nick-kentik opened this issue Dec 18, 2024 · 0 comments
Open

Comments

@nick-kentik
Copy link

nick-kentik commented Dec 18, 2024

First, thanks for Sloth!

This issue is like #280 in concept, just for a different fork of PromQL - https://docs.victoriametrics.com/metricsql/

Trying to use MetricsQL-only functions in Sloth results in an error. The actual promparse errors are not passed to the user, but if you wire up the promql parser manually, you can get them. Depending on the query, you might see, e.g.:

1:1: parse error: unknown function with name "histogram_share"

The issue is exacerbated relative to LogQL as victoriametrics pushes its own custom histograms (a bit similar to the new prometheus native histogram) which use a vmrange label instead of le: https://valyala.medium.com/improving-histogram-usability-for-prometheus-and-grafana-bc7e5df0e350

To get an le-labeled equivalent, you need to use the MetricsQL-specific function prometheus_buckets, so building a good latency SLI against anything using a victoriametrics-format histogram - including victoriametrics itself - seems to be impossible at the moment.

Another alternative suggested on in the LogQL issue would be to add a flag allowing validation to be skipped. Happy to work on either approach, and on making the parse errors more visible, if a fix would be welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant