-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement api key and secret authentication #982
Comments
The decision was to start with an implementation of api/secret keys to replace machine cookies and to provide general, revocable API access to the service. The essential features of the implementation are:
The details of the proposal and discussion can be found in another ticket. |
The attached PR implements all of the above features, except allowing the user to limit the roles for the API key and secret. Testing with a live SlipStream instance still needs to be carried out. |
The roles stored when creating an API key credential also stores the current session role. This should be stripped so that future sessions do not have multiple session roles. |
The latest changes fix the problem with the duplicated session roles. |
Reimplementation of the machine cookies is covered in a separate ticket. #1151 |
Currently machine cookies are used to allow access to SlipStream resources from the orchestrators/machines in a deployment. Investigate whether we should change this implementation or improve the existing one. For example, the existing one could be enhanced to provide further checks on the cookie. A different implementation would be to use revocable api/secret keys, which would be valid only for the lifetime of a given deployment.
The text was updated successfully, but these errors were encountered: