-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grunt Added #35
base: master
Are you sure you want to change the base?
Grunt Added #35
Conversation
Added Grunt functionality for: -js concatenation and minification -image optimization -css to less
Thank you for this. I will review. Grunt was one thing I wanted to make sure was implemented for 1.0 |
imagemin is not stable, it can nuke your project images.
I had to disable the imagemin function in the gruntfile. Turns out it's not stable and sometimes instead of optimizing images, will instead nuke them. |
Any news on approving this for master? |
gitignore fixed to ignore /node_modules it was sloppy of me to commit the dependencies folder in the first place.
When you run grunt for the first time these dependencies are downloaded, no need to include them in the project files.
I updated the .gitignore to ignore the /node_modules folder. That folder is all grunt dependencies that get downloaded the first time you run grunt. No reason for it to be included in the git repo. |
Hello! Soon :) I've been away on business. I'm back and plan to start reviewing pull requests and pushing on towards 1.0. Thanks! Dan |
Not sure where to put this, maybe in the read me. For those not familiar with grunt, make sure you install it, I suggest this guide: http://www.ghosthorses.co.uk/production-diary/installing-grunt-on-os-x-and-windows-7/
|
call_user_func() expects parameter 1 to be a valid callback I don’t know what caused this. So I grabbed a fresh version of brew and re-added: -Gruntfile.js -package.json -updated .gitignore
@colinsteinmann or @slightlyoffbeat - How would i go about grabbing these files so i run grunt on my vagrant box? |
Hey Tanner, Are you just asking how to grab the fork of the brew theme with grunt files included? Or are you asking something specific about using these files with Vagrant?
P.S. The grunt fork is no doubt a little bit behind the master fork at this point, so be aware of this tradeoff. |
Hey Slightlyoffbeat, Any idea when you plan to merge the pull request?
|
Hey Dan,
Codekit is great, but I've outgrown it.
Grunt.js is the heavy duty taskrunner, for folks who need a little more elbow grease than Codekit has. I created the gruntfiles necessary for brew. Please consider adding them into the master.
Added Grunt functionality for:
-js concatenation and minification
-image optimization
-css to less