Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dropping python v3.8, update dependencies, adapt unit-test based on API changes #188

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

amirhessam88
Copy link
Member

@amirhessam88 amirhessam88 commented Jul 17, 2024

…nges ...

Description

  • The main changes are based on the possible glmnet clone based on our opened issue (Python 3.9 Compatibility civisanalytics/python-glmnet#76).
  • Respectively, python v3.8 has been dropped and v3.12 is added.
  • CI scripts changed to run test for all supported python versions except python 3.12. Windows, and Mac OS will be added in a separate PR.
  • Dependency versions are now more loose w.r.t previous versions.
  • Unit-tests are adapted based on the API changes (e.g. Bayesian Optimization or Shap).

Pull Request Checklist

  • Added tests for added or changed code.
  • Added documentation for changed code.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (8b0d7d7) to head (1ce6e49).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          24       24           
  Lines        1906     1907    +1     
  Branches      211      211           
=======================================
+ Hits         1856     1857    +1     
  Misses         24       24           
  Partials       26       26           
Flag Coverage Δ
unittests 97.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amirhessam88 amirhessam88 merged commit 8fda373 into master Jul 17, 2024
4 checks passed
@amirhessam88 amirhessam88 deleted the amir/deps branch July 17, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant