Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack4 support #7

Open
JimBledsoe opened this issue Sep 4, 2018 · 0 comments · May be fixed by #8
Open

Webpack4 support #7

JimBledsoe opened this issue Sep 4, 2018 · 0 comments · May be fixed by #8

Comments

@JimBledsoe
Copy link

Webpack 3 works just fine with the current version, but Webpack4 does not.

Webpack4 made many breaking changes to the bundling process:

  1. The CommonsChunk plugin has been deprecated. The webpack configs are no longer compatible between v3 and v4.
  2. The new bundler uses chunkGroups to handle most of the work of parsing through the chunks manually and the chunk.getParents() method has been deprecated.

This solution was crafted off the master branch before I noticed there was an abandoned devel branch that addressed several other issues already. The devel branch was refactored significantly, so this solution would also have to be refactored to become part of the devel branch. If I was to do this again, I probably would not have made V3/V4 references and just stuck with chunk/chunkGroup references.

Submitting this as reference for others who wish to continue to use this plugin with webpack 4.

@JimBledsoe JimBledsoe linked a pull request Sep 4, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant