From eda2fe92fc347ddc7d92c8a3a4071dec64cefe8d Mon Sep 17 00:00:00 2001
From: John Maguire <contact@johnmaguire.me>
Date: Mon, 8 Jan 2024 17:21:02 -0500
Subject: [PATCH] fix try 2

---
 .github/workflows/release.yml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 1c95bc0d3..2035b6a5e 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -119,29 +119,35 @@ jobs:
       HAS_DOCKER_CREDS: ${{ secrets.DOCKERHUB_USERNAME != '' && secrets.DOCKERHUB_TOKEN != '' }}
       DOCKER_IMAGE_NAME: ${{ env.DOCKER_IMAGE_NAME || 'nebula' }}
       DOCKER_IMAGE_TAG: ${{ env.DOCKER_IMAGE_TAG || 'latest' }}
-    if: ${{ env.HAS_DOCKER_CREDS == 'true' }}
+    # XXX It's not possible to write a conditional here, so instead we do it on every step
+    #if: ${{ env.HAS_DOCKER_CREDS == 'true' }}
     steps:
       # Be sure to checkout the code before downloading artifacts, or they will
       # be overwritten
       - name: Checkout code
+        if: ${{ env.HAS_DOCKER_CREDS == 'true' }}
         uses: actions/checkout@v3
 
       - name: Download artifacts
+        if: ${{ env.HAS_DOCKER_CREDS == 'true' }}
         uses: actions/download-artifact@v2
         with:
           name: linux-latest
           path: ./release/linux/
 
       - name: Login to Docker Hub
+        if: ${{ env.HAS_DOCKER_CREDS == 'true' }}
         uses: docker/login-action@v3
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: Set up Docker Buildx
+        if: ${{ env.HAS_DOCKER_CREDS == 'true' }}
         uses: docker/setup-buildx-action@v3
 
       - name: Build and push images
+        if: ${{ env.HAS_DOCKER_CREDS == 'true' }}
         run: |
           make DOCKER_IMAGE_NAME="${DOCKER_IMAGE_NAME}" DOCKER_BUILD_ARGS="--push" all-docker